fix: consensus invalid block and version test improvement #2789
+258
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhhp1069
requested review from
jaekwon,
moul,
piux2 and
zivkovicmilos
as code owners
thehowl
reviewed
Sep 20, 2024
Comment on lines
+23
to
+24
| sort.Slice(vs, func(i, j int) bool { | ||
| return vs[i].Name < vs[j].Name |
There was a problem hiding this comment.
if the two names are ==, this code should panic.
Comment on lines
+13
to
+15
| Name string | ||
| Version string | ||
| Optional bool |
| for _, pv := range pvs { | ||
| pv := pv | ||
| name2Pair[pv.Name] = &pvpair{&pv, nil} | ||
| // CompatibleWith checks compatibility between two VersionSets. |
| /* | ||
| Invalid blocks don't pass | ||
| */ | ||
| for _, tc := range testCases { | ||
| block, _ := state.MakeBlock(height, makeTxs(height), lastCommit, proposerAddr) | ||
| tc.malleateBlock(block) | ||
| err := blockExec.ValidateBlock(state, block) | ||
| require.Error(t, err, tc.name) | ||
|
|
||
| require.Error(t, err, "%s", tc.name) |
| }{ | ||
| {"BlockVersion wrong", func(block *types.Block) { block.Version += "-wrong" }}, |
There was a problem hiding this comment.
you did well to add expectedError. what would you say about adding them also to all these previous tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description