feat: restore PatchInstanceMethod #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
功能没问题，麻烦补一个测试用例 |
taoso
reviewed
May 7, 2024
monkey.go
Outdated
| panic(fmt.Sprintf("unknown method %s", methodName)) | ||
| } | ||
|
|
||
| o := &opt{} |
There was a problem hiding this comment.
此处可能有问题。monkey 默认开启协程隔离，原来的 PatchInstanceMethod 函数是全局 patch 吧？需要指定 global 参数。
There was a problem hiding this comment.
使用 global: true 测试会失败，我不太熟悉之前的代码，这个地方是不是不需要设置？
taoso
reviewed
May 7, 2024
monkey_test.go
Outdated
| @@ -90,7 +90,7 @@ func (f *f) No() bool { return false } | |||
| func TestOnInstanceMethod(t *testing.T) { | |||
| i := &f{} | |||
| assert(t, !i.No()) | |||
| monkey.Patch((*f).No, func(_ *f) bool { return true }) | |||
| monkey.PatchInstanceMethod(reflect.TypeOf(i), "No", func(_ *f) bool { return true }) | |||
| assert(t, i.No()) | |||
| assert(t, monkey.UnpatchInstanceMethod(reflect.TypeOf(i), "No")) | |||
There was a problem hiding this comment.
这个 UnpatchInstanceMethod 有问题。PatchInstanceMethod 函数返回 guard 对象，调用其 Unpatch 函数来取消 mock。
|
看起来 macos-latest runner 开始使用 arm64 架构的版本了，但是代码还不支持，所以测试失败了 |
|
修好了 #21 rebase master 分支试试 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #19