Add IGameInventory.GetInventoryItems #2008
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazWolfe
reviewed
Aug 12, 2024
| @@ -403,6 +403,9 @@ internal class GameInventoryPluginScoped : IInternalDisposableService, IGameInve | |||
| /// <inheritdoc/> | |||
| public event IGameInventory.InventoryChangedDelegate<InventoryItemMergedArgs>? ItemMergedExplicit; | |||
|
|
|||
| /// <inheritdoc/> | |||
| public ReadOnlySpan<GameInventoryItem> GetInventoryItems(GameInventoryType type) => GameInventoryItem.GetReadOnlySpanOfInventory(type); | |||
There was a problem hiding this comment.
How is it that this use case hasn't come up yet?
No, legitimately. It seems weird to the point of being intentional that this has yet to be a thing.
There was a problem hiding this comment.
Because everyone that needs inventory items uses InventoryManager directly? I don't know. 🤷♂️
I think its weird that Dalamud has a IGameInventory service and you can't even read the inventories with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
GetInventoryItemsfunction toIGameInventory, which returns aReadOnlySpan<GameInventoryItem>of all slots in the container.I can't think of any inventory container that ues symbolic links. My guess is that they are only used in Agents and such, so we don't have to worry about it. I even checked the containers MailEdit and HandIn, surprisingly no symbolic links.
I guess we'll hear when someone has trouble with it.