Update Lumina and use MacroStringParser #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soreepeong
force-pushed
the
luminaupdate
branch
from
46c51a6
to
0192d1e
Compare
|
These changes are API breaking - am I to assume that the things they're replacing are still new enough to not see widespread adoption? If not, we may need to defer this to api11. |
KazWolfe
reviewed
Sep 13, 2024
Dalamud/Interface/ImGuiSeStringRenderer/Internal/SeStringRenderer.cs
Outdated
Show resolved
Hide resolved
No longer requires hook and main thread requirements on compiling macro strings. Needs lookup table fixing on Lumina; using reflection to fix for the time being.
Soreepeong
force-pushed
the
luminaupdate
branch
from
0192d1e
to
bfa7c53
Compare
|
Updated to 4.2.1 and it seems that extension methods will not be referred to if the original class has the correspondingly signatured functions from future compilation; restored |
|
The one breaking change in Lumina is from a base class that is not supposed to be implemented by plugins anyway, so it should be fine. |
KazWolfe
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer requires hook and main thread requirements on compiling macro strings.
Needs lookup table fixing on Lumina; using reflection to fix for the time being.