Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wording #9943

Closed
wants to merge 173 commits into from
Closed

Improve wording #9943

wants to merge 173 commits into from

Conversation

danila-zol
Copy link

No description provided.

russellsanborn and others added 30 commits July 6, 2024 08:41
Co-authored-by: A Thousand Ships <[email protected]>
`AnimationNode`'s inherited classes are `Resource`, `RefCounted`, and `Object`.

I assume it meant to say "derived classes", or something along the lines of
"and all classes which inherit it".
…ure-docs-gdextension-system

Fix project structure diagram in gdextension docs system docs
…on-manual

Fix glTF capitalization in manual
Add commas before "but" throughout documentation
…nced-postprocessing

Fix compile error in advanced_postprocessing.rst
In "avoidance_priority" property description, changed "important npcs characters" to "important non playable characters". The term "npc", means "non playable character", so to say "non playable characters characters" seems like an error.
Corrected grammar on line 141
Fixing issues/9775
codingthat and others added 23 commits September 6, 2024 22:57
* Fix typos in tutorials/animation/introduction.rst

* Grammar fix
…test-py

Add note about the create_test.py script
…essing-example

Add example to advanced_postprocessing.rst
…om-metadata-correction

Tileset custom metadata correction
Document reflection probe limitations in compatability renderer
Add note about limitations of macOS export from Windows.
…75c76

classref: Sync with current master branch (5675c76)
…ple-fix-add-property

Fix `ADD_PROPERTY()` calls in GDExtension C++ example to use correct syntax
…lwatcher-section

Document testing signals
Update release support timelines: 4.4 ETA, 3.6 is released
Correct "ConnectionCheck" return type
…b_actions/peter-evans/create-pull-request-7

Bump peter-evans/create-pull-request from 6 to 7
Fix comment syntax in chroma key example shader
Add 3->4 upgrading information about NDC, light(), and reverse-z
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to target the master branch, not 4.3. Changes that are relevant get cherry picked to 4.3. We have a guide on how to change that here or you could close this PR and open a new one, either works.

@danila-zol
Copy link
Author

My bad, rebased and opened PR #9945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.