Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ enhancement: use msgp for flash message encoding/decoding #3099
✨ enhancement: use msgp for flash message encoding/decoding #3099
Changes from 3 commits
2a73d5a
d73ff5a
5956dde
305c539
bbe74e8
3adc842
bff1f6c
f6cf451
da8473c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 123 in redirect.go
Codecov / codecov/patch
redirect.go#L122-L123
Check warning on line 125 in redirect.go
Codecov / codecov/patch
redirect.go#L125
Check warning on line 150 in redirect.go
Codecov / codecov/patch
redirect.go#L150
Check warning on line 152 in redirect.go
Codecov / codecov/patch
redirect.go#L152
Check warning on line 200 in redirect.go
Codecov / codecov/patch
redirect.go#L200
Check warning on line 232 in redirect.go
Codecov / codecov/patch
redirect.go#L232
Check warning on line 305 in redirect.go
Codecov / codecov/patch
redirect.go#L305
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add error handling to
parseAndClearFlashMessages
method.The method lacks error handling for the unmarshaling process. Consider adding error handling to ensure robustness.
Apply this diff to add error handling:
Committable suggestion
Tools
GitHub Check: codecov/patch
Check warning on line 318 in redirect.go
Codecov / codecov/patch
redirect.go#L318
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add error handling to
processFlashMessages
method.The method lacks error handling for the marshaling process. Consider adding error handling to ensure robustness.
Apply this diff to add error handling:
Committable suggestion
Tools
GitHub Check: codecov/patch