Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stasher/azure blob test: use - instead of _ for container name #1366

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

marpio
Copy link
Member

@marpio marpio commented Aug 30, 2019

_ is an invalid char in container name so let's use - instead.

@marpio marpio requested a review from a team as a code owner August 30, 2019 20:14
Copy link
Member

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one request, @marpio
Otherwise, this looks awesome, thanks! 🎉

return nil
}
name := os.Getenv("ATHENS_AZURE_ACCOUNT_NAME")
name := "athens" //os.Getenv("AZURE_ACCOUNT_NAME")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the commented os.Getenv call?

@arschles
Copy link
Member

@marpio Are you up for continuing with this PR? No pressure either way, just let me know and I can pick it up if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants