chore: add webdriver tests for workspace comments #7954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
chore/comment-visual-tests
branch
from
4f371f2
to
dccc56f
Compare
|
This is the last PR on the workspace comments chain before it "merges" with the dragging chain! So from here on it'll just be one PR up for review instead of two in parallel. |
rachel-fenichel
approved these changes
Apr 4, 2024
github-actions
bot
added
PR: chore
johnnesky
pushed a commit
to johnnesky/blockly
that referenced
this pull request
Apr 13, 2024
* chore: add collapse and uncollapse tests * chore: add typing test * chore: add resizing test * chore: add delete tests * chore: add better assertion messages * chore: copyright year
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8003
Proposed Changes
Adds some visual tests to theoretically catch bugs in the future.
Test Coverage
This is tests!
Documentation
N/A
Additional Information
N/A