fix: dragging shadow blocks #7992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
fix/dragging-shadows
branch
from
c16d490
to
f69c396
Compare
rachel-fenichel
approved these changes
Apr 4, 2024
johnnesky
pushed a commit
to johnnesky/blockly
that referenced
this pull request
Apr 13, 2024
* fix: dragging shadow blocks * fix: dragging shadows not reverting them to their original position * fix: shadow parents not being deselected
BeksOmega
added a commit
to BeksOmega/blockly
that referenced
this pull request
May 16, 2024
This reverts commit c0e6e67.
BeksOmega
added a commit
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes N/A
Proposed Changes
#7991 Broke dragging shadow blocks, but this PR fixes it again.
Test Coverage
Tested that dragging shadows, including shadows who are children of shadows, drags the nearest parent real block
Documentation
N/A
Additional Information
N/A