Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: visual comment selection #7996

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented Apr 2, 2024

The basics

The details

Resolves

Fixes #8007

Proposed Changes

Adds visually highlighting workspace comments when they are selected

Test Coverage

Screen recording 2024-04-02 3 01 38 PM

Documentation

N/A

Additional Information

N/A

@github-actions github-actions bot added the PR: feature Adds a feature label Apr 2, 2024
@BeksOmega BeksOmega marked this pull request as ready for review April 5, 2024 16:23
@BeksOmega BeksOmega requested a review from a team as a code owner April 5, 2024 16:23
@BeksOmega BeksOmega requested a review from maribethb April 5, 2024 16:23
@BeksOmega BeksOmega requested review from rachel-fenichel and removed request for maribethb April 5, 2024 17:15
@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Apr 5, 2024
@@ -124,6 +131,14 @@ export class CommentView implements IRenderedElement {
this.moveTo(new Coordinate(0, 0));
}

private createHighlightRect(svgRoot: SVGGElement): SVGRectElement {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tsdoc

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to turn the lint warnings for this back on?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope.

@BeksOmega BeksOmega enabled auto-merge (squash) April 5, 2024 20:33
@BeksOmega BeksOmega merged commit e1cbddd into google:rc/v11.0.0 Apr 5, 2024
6 checks passed
johnnesky pushed a commit to johnnesky/blockly that referenced this pull request Apr 13, 2024
* feat: add visually highlighting selected comment

* chore: TSDoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants