fix: blocks not being returned to the correct layer if their drag is reverted with no parent #7998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g is reverted with no parent
BeksOmega
force-pushed
the
fix/blocks-revert-move
branch
from
37b0ffb
to
9d7e403
Compare
maribethb
reviewed
Apr 5, 2024
maribethb
approved these changes
Apr 8, 2024
johnnesky
pushed a commit
to johnnesky/blockly
that referenced
this pull request
Apr 13, 2024
…reverted with no parent (google#7998) * fix: blocks not being returned to the correct drag layer if their drag is reverted with no parent * fix: delete test code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes N/A
Proposed Changes
See PR title.
Test Coverage
Tested that blocks that didn't have parents when their drag started are properly returned to the
BLOCKlayer.Documentation
N/A
Additional Information
N/A