Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: rename the blockly icon CSS classes to use camelCase (#8329) #8335

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

ga-fleury
Copy link

The basics

The details

Resolves

Fixes Rename the blockly icon CSS classes to use camelCase #8329

Proposed Changes

Rename the following CSS classes and references to them:

.blockly-icon-comment -> blocklyCommentIcon
.blockly-icon-warning -> blocklyWarningIcon
.blockly-icon-mutator -> blocklyMutatorIcon

Reason for Changes

Test Coverage

Documentation

Additional Information

@ga-fleury ga-fleury requested a review from a team as a code owner July 12, 2024 13:15
@ga-fleury ga-fleury requested a review from BeksOmega July 12, 2024 13:15
@BeksOmega BeksOmega changed the title Rename the blockly icon CSS classes to use camelCase (#8329) fix!: rename the blockly icon CSS classes to use camelCase (#8329) Jul 12, 2024
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug labels Jul 12, 2024
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll get this merged once it passes CI

@BeksOmega BeksOmega merged commit 9ba791c into google:rc/v12.0.0 Jul 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants