Skip to content

Commit

Permalink
web: remove const qualifier for getMaterialInstances
Browse files Browse the repository at this point in the history
  • Loading branch information
mackong committed Jul 19, 2023
1 parent 18c3c36 commit 97adec4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions web/filament-js/jsbindings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ using EntityVector = std::vector<utils::Entity>;
register_vector<std::string>("RegistryKeys");
register_vector<utils::Entity>("EntityVector");
register_vector<FilamentInstance*>("AssetInstanceVector");
register_vector<const MaterialInstance*>("MaterialInstanceVector");
register_vector<MaterialInstance*>("MaterialInstanceVector");

// CORE FILAMENT CLASSES
// ---------------------
Expand Down Expand Up @@ -1907,10 +1907,10 @@ class_<FilamentInstance>("gltfio$FilamentInstance")

.function("applyMaterialVariant", &FilamentInstance::applyMaterialVariant)

.function("getMaterialInstances", EMBIND_LAMBDA(std::vector<const MaterialInstance*>,
.function("getMaterialInstances", EMBIND_LAMBDA(std::vector<MaterialInstance*>,
(FilamentInstance* self), {
const MaterialInstance* const* ptr = self->getMaterialInstances();
return std::vector<const MaterialInstance*>(ptr, ptr + self->getMaterialInstanceCount());
MaterialInstance* const* ptr = self->getMaterialInstances();
return std::vector<MaterialInstance*>(ptr, ptr + self->getMaterialInstanceCount());
}), allow_raw_pointers())

.function("_getMaterialVariantNames", EMBIND_LAMBDA(std::vector<std::string>, (FilamentInstance* self), {
Expand Down

0 comments on commit 97adec4

Please sign in to comment.