Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For web assembly, implement logging as emscripten_err and emscripten_out #6913

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

bejado
Copy link
Member

@bejado bejado commented Jun 21, 2023

This avoids the need to use posix filesystem APIs just to write to stderr and stdout. These emscripten APIs behave the same as stdout/stderr as observed by the web assembly host.

Mirror of cl/540668528

@bejado bejado requested a review from poweifeng June 21, 2023 06:55
@bejado bejado added the internal Issue/PR does not affect clients label Jun 21, 2023
@google google deleted a comment from github-actions bot Jun 21, 2023
@bejado bejado merged commit 9fa952d into main Jun 22, 2023
8 of 9 checks passed
@bejado bejado deleted the bjd/web-assembly branch June 22, 2023 03:18
plepers pushed a commit to plepers/filament that referenced this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Issue/PR does not affect clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants