fix FrameSkipper #8110
Merged
fix FrameSkipper #8110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrameSkipper was recently broken because of a typo resulting in the frame latency being always 3 instead of the default of 2. This change also makes the maximum latency 2 instead of 3, because on ANDROID, 3 can cause CPU throttling at seemingly random places on the GL thread.
poweifeng
approved these changes
Sep 9, 2024
filament/src/FrameSkipper.h
Outdated
| static constexpr size_t MAX_FRAME_LATENCY = 3; | ||
| /* | ||
| * The maximum frame latency acceptable on ANDROID is 2 because higher latencies will be | ||
| * throttled anyway is BufferQueueProducer::dequeueBuffer(), because ANDROID is generally |
pixelflinger
commented
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FrameSkipper was recently broken because of a typo resulting in the frame latency being always 3 instead of the default of 2.
This change also makes the maximum latency 2 instead of 3, because on ANDROID, 3 can cause CPU throttling at seemingly random places on the GL thread.