First attempt to port the repo from python2 to python3 with 2to3 #79

cgl · 2018-09-18T19:27:01Z

Also here is a small how to install the repo for development :)

brew install go

Fork and clone the repo

cd grumpy-tools-src/
python setup.py develop

cd grumpy-runtime-src/
python setup.py develop

pip install pytest pytest-cov

pytest

alanjds · 2018-10-09T17:48:54Z

@grumpyhome/reviewers: Maybe we should talk about supporting Python 3.X host at least. Not about supporting code, this is about the interpreter that runs the transpilation tools.

This branch allows a machine with Python 3 installed to run Grumpy. We will need to talk about pythonparser and stdlib issues, but it should occur someday.

cclauss · 2018-10-09T17:50:29Z

Caution: 2to3 often breaks Python 2 code to achieve Python 3 functionality. Given that we want code that is compatible with BOTH Python 2 AND Python 3, I would advise avoiding 2to3 and going with http://python-future.org or https://python-modernize.readthedocs.io instead. I like futurize but others might disagree.

alanjds · 2018-10-09T17:52:34Z

I think the same. @cgl coded a proof of concept, if I understood correctly.

Looks like is not that hard to make Grumpy work with a Python 3 host.

alanjds · 2018-10-09T17:56:14Z

To be clear: I am not proposing to merge something that works for Py3 and breaks the Py2 tests. At least not on this decade

It is for talking about how to support Py3 host too, given that it is possible.

cclauss

A few areas where 2to3 breaks Python 2.

cclauss · 2018-10-09T17:56:42Z

grumpy-runtime-src/lib/weetest.py

@@ -96,19 +96,19 @@ def _RunOneBenchmark(name, test_func):
  """Runs a single benchmark and returns a _TestResult."""
  b = _Benchmark(test_func, 1)
  result = _TestResult(name)
-  print name,
+  print(name, end=' ')


if from __future__ import print_function is not placed at the top of this file before all other imports then this line will by a syntax error in Python 2.

cclauss · 2018-10-09T17:58:05Z

grumpy-runtime-src/lib/weetest.py

    traceback.print_exc()
  else:
    result.status = 'passed'
    ops_per_sec = b.N / b.duration
    result.properties['ops_per_sec'] = ops_per_sec
-    print 'PASSED', ops_per_sec
+    print('PASSED', ops_per_sec)


if from future import print_function is not placed at the top of this file before all other imports then this line will print something different that expected in Python 2.

cclauss · 2018-10-09T18:00:34Z

grumpy-runtime-src/testing/str_test.py

@@ -18,7 +18,7 @@

 # Test Add
 assert "foo" + "bar" == "foobar"
-assert "foo" + u"bar" == u"foobar"
+assert "foo" + "bar" == "foobar"


This removal is unnecessary in all currently supported versions of CPython (2.7, 3.4, 3.5, 3.6, 3.7)

The meaning changed. Should be b"foo" + u"bar" == u"foobar" I guess.

alanjds · 2018-12-04T23:36:32Z

Given that is about Xmas and we are far from getting Py 2.7 compliance, how do you feel about changing the whole toolchain and target to, lets say, Python 3.4 ?

cclauss · 2018-12-04T23:46:34Z

Why target 3.4 when it's EOL date is just 3 months after Python 2's??

My vote would be a direct shift from Python 2.7 to Python 3.7. It is going to take us years to get there and anything less than Py37 will already be EOL by the time we reach the finish line.

EOL dates are https://devguide.python.org/#branchstatus

alanjds · 2018-12-05T02:49:40Z

I see. You are right on this point.

My concern is that implementing syntax changes is yet hard for me. I am still struggling to properly get Docstrings to work.

3.5 includes async/await, that are really awesome and have a great fit with the Go programming style. But will take looong to be done, for example.

At least 2.7 syntaxes are done, and up to 3.4 I do not remember anything bizarre that got added.

andgrew · 2018-12-23T17:40:51Z

I think it would be great to teach grumpy to determine which python we are, so in to continue transcode based on this environment. So py7 functionality can stay unchanged.

At the same time, everyone who can not wait to teach grumpy Py3 (me too) could debug it for the main branch. What do you think?

alanjds · 2019-01-07T19:35:42Z

@andgrew it mostly works, but the tests infrastructure do compare system Python output to Grumpy output, and Grumpy will be different than Py3k at the 1st moment at least.

Your idea is reasonable, but how to handle this?

andgrew · 2019-01-07T21:05:01Z

Your idea is reasonable, but how to handle this?

I think we should keep working tests for the py2 environment, while at the same time correcting breaking tests for the py3 environment step by step.

I can take the task of introducing such system with your consent. Or it's yours, @alanjds ? Although I have not yet figured out all the mechanisms of Grumpy, but here everything is clear, so it is just need to implement. and it's interesting for me.

alanjds · 2019-01-08T13:11:59Z

Consent? :P

Go ahead!. My actual task is to reimplement the _codecs interface in pure-python. But I believe that Py3 support will unlock more people to help. Is hard to convince anyone to install something that will be deprecated by the end of this year (2019).

Go ahead. I will help as much as I can. Open issues, send PRs, ask for help.

I really liked the approach @cclauss suggested about using https://python-modernize.readthedocs.io on the whole codebase. But I would do it per-module instead, to be able to bissect the bugs between the commits.

cgl and others added 5 commits September 18, 2018 20:23

First attempt to port the repo from python2 to python3

f0dbceb

more refactoring

e19c142

more refactoring on tools folder

51bd894

Merge branch 'master' into fix/python2to3

a0f0bc9

fix conflict with io library and io var

9da8b88

alanjds requested a review from a team October 9, 2018 17:45

cclauss requested changes Oct 9, 2018

View reviewed changes

alanjds mentioned this pull request Oct 23, 2018

Could not compile on 16.04.5 LTS Xenial Xerus (Was: How to transcompile python code that have logging or psutil libraries imported.) #112

Open

andgrew self-requested a review December 23, 2018 17:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First attempt to port the repo from python2 to python3 with 2to3 #79

First attempt to port the repo from python2 to python3 with 2to3 #79

cgl commented Sep 18, 2018 •

edited by alanjds

Loading

alanjds commented Oct 9, 2018

cclauss commented Oct 9, 2018 •

edited

Loading

alanjds commented Oct 9, 2018

alanjds commented Oct 9, 2018

cclauss left a comment

cclauss Oct 9, 2018

cclauss Oct 9, 2018

cclauss Oct 9, 2018

alanjds Oct 9, 2018

alanjds commented Dec 4, 2018

cclauss commented Dec 4, 2018

alanjds commented Dec 5, 2018

andgrew commented Dec 23, 2018

alanjds commented Jan 7, 2019

andgrew commented Jan 7, 2019

alanjds commented Jan 8, 2019

First attempt to port the repo from python2 to python3 with 2to3 #79

Are you sure you want to change the base?

First attempt to port the repo from python2 to python3 with 2to3 #79

Conversation

cgl commented Sep 18, 2018 • edited by alanjds Loading

alanjds commented Oct 9, 2018

cclauss commented Oct 9, 2018 • edited Loading

alanjds commented Oct 9, 2018

alanjds commented Oct 9, 2018

cclauss left a comment

Choose a reason for hiding this comment

cclauss Oct 9, 2018

Choose a reason for hiding this comment

cclauss Oct 9, 2018

Choose a reason for hiding this comment

cclauss Oct 9, 2018

Choose a reason for hiding this comment

alanjds Oct 9, 2018

Choose a reason for hiding this comment

alanjds commented Dec 4, 2018

cclauss commented Dec 4, 2018

alanjds commented Dec 5, 2018

andgrew commented Dec 23, 2018

alanjds commented Jan 7, 2019

andgrew commented Jan 7, 2019

alanjds commented Jan 8, 2019

cgl commented Sep 18, 2018 •

edited by alanjds

Loading

cclauss commented Oct 9, 2018 •

edited

Loading