Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clear Search Query Button #198

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

edmondchui
Copy link

Add a clear button at the end of the search input field to clear the search query upon clicking.

The clear button will only appear when the search query is non-empty.

I don't know which tool you are using the build the JS build version so I just modify the javascript in src and dist directories.

@guylabs guylabs added this to the Backlog milestone Sep 18, 2016
@guylabs
Copy link
Owner

guylabs commented Sep 18, 2016

Hi @edmondchui,

thanks for the PR. Could you maybe add some e2e tests if you want this feature to be merged with the master? And I use Grunt to build so you would need to execute the build task to build, test and package everything. Could you maybe do this and update the PR?

Thanks and regards,

Guy

@coveralls
Copy link

coveralls commented Nov 6, 2016

Coverage Status

Coverage decreased (-0.7%) to 73.77% when pulling 79a29d3 on edmondchui:master into 8017199 on guylabs:master.

Merge change from fork base guylabs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants