Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpreter can't reduce top-level definitions #1247

Open
3 tasks done
dhess opened this issue Apr 20, 2024 · 0 comments
Open
3 tasks done

Interpreter can't reduce top-level definitions #1247

dhess opened this issue Apr 20, 2024 · 0 comments
Assignees
Labels
bug 🐞 A confirmed bug primer Specific to the primer package priority: high This issue has high priority

Comments

@dhess
Copy link
Member

dhess commented Apr 20, 2024

Code of conduct

  • I've read the project's code of conduct, and agree to follow it.

Don't report security issues here

  • I've read the project's security policy, and I do not believe this bug is a security issue.

Is there an existing issue?

  • I've searched GitHub Issues, and I believe this is a new issue

What happened?

While adding the interpreter to the various Primer APIs, I discovered that the interpreter can't reduce top-level definitions. This test demonstrates that the interpreter can't evaluate the even 3? top-level definition in our example even3Prog:

What should have happened?

The interpreter should be able to reduce a top-level definition whose root node is an App.

Which package(s) or aspect(s) of the project are the source of the issue?

primer

Developers, please provide the output of the bug report script

No response

Do you have a reproducer?

Yes, see above.

Any additional information?

We can't use the interpreter in the frontend until this issue is resolved. See hackworthltd/primer-app#1169

@dhess dhess added the triage This issue needs triage label Apr 20, 2024
@dhess dhess self-assigned this Apr 20, 2024
@dhess dhess added priority: high This issue has high priority bug 🐞 A confirmed bug primer Specific to the primer package and removed triage This issue needs triage labels Apr 20, 2024
dhess added a commit that referenced this issue Apr 22, 2024
Note that all of these tests that use the interpreter are currently
expected to fail (or are commented out because they will fail) due to
#1247

Signed-off-by: Drew Hess <[email protected]>
dhess added a commit to hackworthltd/primer-app that referenced this issue Apr 23, 2024
This is more or less a drop-in replacement for `EvalFull` and is ready
to go, save for hackworthltd/primer#1247.
Therefore, we don't yet use it in the `Edit` and `PictureInPicture`
components.

Signed-off-by: Drew Hess <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 A confirmed bug primer Specific to the primer package priority: high This issue has high priority
Projects
None yet
Development

No branches or pull requests

1 participant