feat: use the interpreter to evaluate top-level definitions #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This all works... except for the interpreter, which appears to be not able to reduce top-level expressions. See hackworthltd/primer#1247 |
dhess
force-pushed
the
dhess/interpreter
branch
from
d9b92b8
to
e99bd8c
Compare
This was referenced Apr 20, 2024
This version of Primer includes the new `evalBoundedInterp` API that uses the interpreter for evaluation, rather than the step evaluator. (Note that we have not switched to the interpreter in this commit; this is only a Primer version bump.) Signed-off-by: Drew Hess <[email protected]>
This is more or less a drop-in replacement for `EvalFull` and is ready to go, save for hackworthltd/primer#1247. Therefore, we don't yet use it in the `Edit` and `PictureInPicture` components. Signed-off-by: Drew Hess <[email protected]>
dhess
force-pushed
the
dhess/interpreter
branch
from
e99bd8c
to
d4ef501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We bump the Primer pin for interpreter support, and create a new
EvalBoundedInterpcomponent that's more or less a drop-in replacement forEvalFull(which uses the much slower step evaluator). However, we don't yet use this in the UI pending the resolution of hackworthltd/primer#1247.