refactor: move eval into a separate primer-eval
package
#1080
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still very much a WIP. The tests need fixing up, and
primer-service
will need to combine the sessions-and-actions API with the factored-out eval API. None of that work has been done yet, butprimer
andprimer-eval
do compile, at least.I'm open to suggestions/techniques for how best to combine the two APIs.
(One could also imagine a further evolution where we move actions & type checking to the frontend, as well, leaving only the sessions API, i.e., program store, for
primer-service
.)