Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace some PNGs with SVGs #562

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jt15s
Copy link
Contributor

@jt15s jt15s commented Sep 8, 2021

Replaced some PNGs with SVGs - not all can be immediately replaced as:

  • The microphone, link_tags and read more icons don't seem to exist in the Haiku Icons repository I am using
  • The Blog and Menu sidebar icons and div alert svgs are cut off for some strange reason and appears too big despite having set it to the correct size
  • I can't find where the large Installer and People icons are kept (i.e. which partial html file points to those images)
  • The download icon does not cooperate well with the other SVGs in the header
  • Exporting the big download button in WB to an SVG doesn't work, the gradients are all wrong
  • Likewise, exporting the System Kernel icon does not work and the resulting SVG is missing some elements

Replaced some PNGs with SVGs - not all can be immediately replaced as:
* The microphone, link_tags and read more icons don't seem to exist in the Haiku Icons repository I am using
* The Blog and Menu sidebar icons and div alert svgs are cut off for some strange reason and appears too big despite having set it to the correct size
* I can't find where the large Installer and People icons are kept (i.e. which partial html file points to those images)
* The download icon does not cooperate well with the other SVGs in the header
* Exporting the big download button in WB to an SVG doesn't work, the gradients are all wrong
* Likewise, exporting the System Kernel icon does not work and the resulting SVG is missing some elements
@mmuman
Copy link
Contributor

mmuman commented Sep 8, 2021

Hmm, would the export depend on the size of the destination image? Some features are only seen at some minimum level of detail.

@jt15s
Copy link
Contributor Author

jt15s commented Sep 8, 2021

Erm, not too sure haha. I just used the SVGs from this repo: https://github.com/darealshinji/haiku-icons

@n0toose
Copy link
Contributor

n0toose commented Dec 7, 2021

Any updates on this?

@ghost
Copy link

ghost commented May 21, 2022

Please hold off on this untill https://dev.haiku-os.org/ticket/17305 is fixed.

@dstaley
Copy link

dstaley commented Dec 24, 2022

Please hold off on this untill dev.haiku-os.org/ticket/17305 is fixed.

It looks like that issue has been resolved.

@ghost
Copy link

ghost commented Dec 2, 2023

Yes, this has been resolved some time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants