Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semver regex #1594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gabriel0316
Copy link
Contributor

@grahamegrieve
Copy link
Collaborator

grahamegrieve commented Apr 10, 2024

I don’t think this is enough by a long shot. If we’re going to allow + in semver versions, it needs a lot of testing so that we know it works across the whole ecosystem. Does the validator support this? Do the package servers support it? Does the publisher support it?

And in the code, does versionutilities support it?

@gabriel0316
Copy link
Contributor Author

I see - yes, that of course makes sense.

But this change may be a good starting point. And, the current version (in production) of the regex already allowed the following: 1.0.0-asdf+asdf+asfd

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.07%. Comparing base (f9a3501) to head (4511275).
Report is 14 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1594      +/-   ##
============================================
+ Coverage     12.05%   12.07%   +0.02%     
- Complexity    31149    31241      +92     
============================================
  Files          2167     2175       +8     
  Lines        670269   670467     +198     
  Branches     197931   197960      +29     
============================================
+ Hits          80773    80945     +172     
- Misses       560400   560407       +7     
- Partials      29096    29115      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grahamegrieve
Copy link
Collaborator

@dotasek for us to discuss next week

@grahamegrieve
Copy link
Collaborator

@grahamegrieve
Copy link
Collaborator

see https://chat.fhir.org/#narrow/stream/179239-tooling/topic/NPM.20.26.20SemVer: it's good to go, and we need to do this across the board

@grahamegrieve
Copy link
Collaborator

to test:

  • support for + in FilesystemBasedPackageCache
  • support for + on packages.fhir.org
  • support in the package client
  • validation in FHIRVersion elements
  • support in go-publish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants