-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update semver regex #1594
base: master
Are you sure you want to change the base?
Update semver regex #1594
Conversation
I don’t think this is enough by a long shot. If we’re going to allow + in semver versions, it needs a lot of testing so that we know it works across the whole ecosystem. Does the validator support this? Do the package servers support it? Does the publisher support it? And in the code, does versionutilities support it? |
I see - yes, that of course makes sense. But this change may be a good starting point. And, the current version (in production) of the regex already allowed the following: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1594 +/- ##
============================================
+ Coverage 12.05% 12.07% +0.02%
- Complexity 31149 31241 +92
============================================
Files 2167 2175 +8
Lines 670269 670467 +198
Branches 197931 197960 +29
============================================
+ Hits 80773 80945 +172
- Misses 560400 560407 +7
- Partials 29096 29115 +19 ☔ View full report in Codecov by Sentry. |
@dotasek for us to discuss next week |
see https://chat.fhir.org/#narrow/stream/179239-tooling/topic/NPM.20.26.20SemVer: it's good to go, and we need to do this across the board |
to test:
|
https://chat.fhir.org/#narrow/stream/179252-IG-creation/topic/Semver.20validation