Include validation of local files #1647
Open
+671
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the load local files approach to include resourceType and id. Added R5EvaluationContext class that stores all local files as Elements (src: ValidatedFragments). Pass R5EvaluationContext as externalHostServices in ValidatorInstance. Changes the order in InstanceValidator.resolveReference to check externalHostServices before context.
Added the option localFile as refType.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for validation of local files.
For this I've updated IGloader to return the loaded resource type and id.
This ValidationEngine will use that information to create a R5EvaluationContext class which is passed to the InstanceValidator. This class holds the files as Elements. When a resource is retrieved using FHIRpath, this element is returned and validated.
To test this I've added a test that loads files and validates them.
Is this an approach that would work?