Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented MainMenu::BeginStartup #99

Merged
merged 14 commits into from
Mar 23, 2024
Merged

Conversation

PieVieRo
Copy link
Contributor

not 100% accurate, but it works

Copy link
Member

@roblabla roblabla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nitpicks, but looks awesome otherwise!

src/MainMenu.hpp Outdated Show resolved Hide resolved
src/MainMenu.cpp Outdated Show resolved Hide resolved
src/MainMenu.cpp Outdated Show resolved Hide resolved
src/MainMenu.cpp Outdated Show resolved Hide resolved
src/MainMenu.cpp Outdated Show resolved Hide resolved
@roblabla
Copy link
Member

Also you need to put the function in config/implemented.csv so it gets picked up by the comparison tracker

Copy link
Member

@roblabla roblabla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thanks for the contribution!

@roblabla roblabla merged commit c8decde into happyhavoc:master Mar 23, 2024
5 checks passed
PieVieRo added a commit to PieVieRo/th06 that referenced this pull request Apr 3, 2024
* implemented MainMenu::BeginStartup

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Robin Lambertz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants