Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2: Run make fumpt #39169

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ec2: Run make fumpt #39169

wants to merge 1 commit into from
+95 −1,052

Conversation

ewbankkit
Copy link
Contributor

Description

Ran gofumpt (via make fumpt) on the ec2 package to see what gets changed.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. sweeper Pertains to changes to or issues with the sweeper. service/ipam Issues and PRs that pertain to the ipam service. service/vpnclient Issues and PRs that pertain to the vpnclient service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/wavelength Issues and PRs that pertain to the wavelength service. service/ec2outposts Issues and PRs that pertain to the ec2outposts service. service/vpc Issues and PRs that pertain to the vpc service. service/vpnsite Issues and PRs that pertain to the vpnsite service. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 5, 2024
@ewbankkit
Copy link
Contributor Author

ewbankkit commented Sep 19, 2024 •
edited
Loading

//nloint: https://golangci-lint.run/usage/false-positives/#nolint-directive

Use //nolint instead of // nolint because machine-readable comments should have no space by Go convention.

https://github.com/mvdan/gofumpt/blob/86bffd62437a3c437c0b84d5d5ab244824e762fc/format/format.go#L303-L314

//lintignore is not in this list, it's a tfproviderlint-specific comment: https://github.com/bflad/tfproviderlint/blob/031f7d1388d98652132b31cd9dac903ddc55b733/passes/commentignore/ignore.go#L12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/ec2outposts Issues and PRs that pertain to the ec2outposts service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ipam Issues and PRs that pertain to the ipam service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. service/vpc Issues and PRs that pertain to the vpc service. service/vpnclient Issues and PRs that pertain to the vpnclient service. service/vpnsite Issues and PRs that pertain to the vpnsite service. service/wavelength Issues and PRs that pertain to the wavelength service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ewbankkit