Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_eks_cluster: Allow unsetting the bootstrap_cluster_creator_admin_permissions (from true to null) without cluster re-creation #39174

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bryantbiggs
Copy link
Contributor

Description

  • Allow unsetting the bootstrap_cluster_creator_admin_permissions (from true to null) without cluster re-creation

Relations

Closes #38967

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

github-actions bot commented Sep 5, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/eks Issues and PRs that pertain to the eks service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Sep 5, 2024
@bryantbiggs
Copy link
Contributor Author

Not certain of the best path to resolve this - currently the test is failing

make testacc TESTS=TestAccEKSCluster_AccessConfigBootstrapClusterCreator_update PKG=eks
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSCluster_AccessConfigBootstrapClusterCreator_update'  -timeout 360m
=== RUN   TestAccEKSCluster_AccessConfigBootstrapClusterCreator_update
=== PAUSE TestAccEKSCluster_AccessConfigBootstrapClusterCreator_update
=== CONT  TestAccEKSCluster_AccessConfigBootstrapClusterCreator_update
    cluster_test.go:214: Step 2/2 error: Check failed: Check 2/5 error: EKS Cluster was recreated
--- FAIL: TestAccEKSCluster_AccessConfigBootstrapClusterCreator_update (707.92s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/eks	708.153s
FAIL
make: *** [GNUmakefile:629: testacc] Error 1

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. partner Contribution from a partner. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants