New Resource: azurerm_advisor_suppression

[jkroepke]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

This resources takes care of advisor suppressions.

API Ref: https://learn.microsoft.com/en-us/rest/api/advisor/suppressions?view=rest-advisor-2023-01-01

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/advisor '-run=TestAccAnalysisServicesServer_basic' -timeout 300m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAnalysisServicesServer_basic
=== PAUSE TestAccAnalysisServicesServer_basic
=== CONT  TestAccAnalysisServicesServer_basic
--- PASS: TestAccAnalysisServicesServer_basic (39.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/advisor	39.703s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• New Resource: azurerm_advisor_suppression [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[jackofallops]

Hi @jkroepke - Thanks for this PR. We are moving away from this style of resource for new resources in favour of "Typed" resource as per the contributor docs here: https://github.com/hashicorp/terraform-provider-azurerm/blob/main/contributing/topics/best-practices.md#typed-vs-untyped-resources
can you take a look at implementing this as a Typed resource?

Additionally, we'd need this PR splitting into separate PRs for the multiple purposes here, i.e. one for updating the API version, one for the additional property support, and of course this one for the new resource.

If you can take a look at those changes, we can continue review.

Thanks

[jkroepke]

Hey @jackofallops do you have any example for where a service directory contains both styles of resources?

[jkroepke]

API Update #26205

[jackofallops]

Hey @jackofallops do you have any example for where a service directory contains both styles of resources?

Hi @jkroepke - Quite a few services make use of both types at present, for example: applicationinsights and containers
Hope that helps?

[jkroepke]

additional property support: #26220

[jkroepke]

Hey @jackofallops

I rewrite the resource based on the given example. Please take a look

[github-actions]

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

[jkroepke]

@katbyte i'm waiting for an response

About CI: I run go mod tidy / go mod vendor locally and I have nothing to commit

[katbyte]

Sorry for the delay @jkroepke - i think describing the format is fine, i've done so and LGTM now 🔬