Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests - servicebus test fixes #27412

Merged
merged 1 commit into from
Sep 19, 2024
Merged

tests - servicebus test fixes #27412

merged 1 commit into from
Sep 19, 2024

Conversation

mbfrahry
Copy link
Member

Many tests were enabling attributes that are ForceNew so we removed the initial test step

@@ -309,7 +309,6 @@ func TestAccAzureRMServiceBusNamespace_networkRuleSet(t *testing.T) {
Config: r.networkRuleSetEmpty(data),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
check.That(data.ResourceName).Key("network_rule_set.0.default_action").HasValue("Allow"),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.0 changed this behavior so we don't need this anymore

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛋️

@mbfrahry mbfrahry merged commit e5eb743 into main Sep 19, 2024
30 checks passed
@mbfrahry mbfrahry deleted the t-service-bus branch September 19, 2024 20:57
@github-actions github-actions bot added this to the v4.3.0 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants