New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix. add a space in promoted list/tuple of some promoted type #423

Open

pierric wants to merge 2 commits into haskell-suite:master from pierric:master

pierric commented Dec 15, 2018

Here is a bug. It happens when pretty print a promoted list or tuple of promoted type. For example:

Prelude Language.Haskell.Exts Language.Haskell.Exts.Syntax Language.Haskell.Exts.Pretty> a = TyPromoted () (PromotedList () True [TyPromoted () (PromotedTuple () [])])
Prelude Language.Haskell.Exts Language.Haskell.Exts.Syntax Language.Haskell.Exts.Pretty> prettyPrint a
"'['()]"

However GHC (8.4.4) does not accept '['()]

A.hs:4:10: error: parse error on input ‘'’
  |
4 | type X = '['()]
  |          ^

So I add one space after the bracket when pretty print. The above example will become "'[ '()]", which makes GHC very happy.


          bug fix. add a space in promoted list/tuple of some promoted type

f75a5db

Author

pierric commented May 1, 2019

any idea about this PR?


          Merge remote-tracking branch 'haskell-suite/master' into master-ori

792ec73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet