Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix-whitespace: show violations (verbose mode) #10374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CI: fix-whitespace: show violations (verbose mode) #10374

wants to merge 1 commit into from

Conversation

ulysses4ever
Copy link
Collaborator

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

geekosaur
geekosaur approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

ffaf1
ffaf1 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@ffaf1 ffaf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happened to me once, wondered why “verbose” was not on.

@ulysses4ever ulysses4ever added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Sep 19, 2024
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Sep 19, 2024
@ulysses4ever
Copy link
Collaborator Author

Thanks all!

I'm unsure about backports: do we want them or not?

@ffaf1
Copy link
Collaborator

ffaf1 commented Sep 19, 2024

Imho not necessary, backported PRs should be free of whitespace problems in any case.

@ulysses4ever
Copy link
Collaborator Author

Agreed! Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekosaur geekosaur geekosaur approved these changes

@ffaf1 ffaf1 ffaf1 approved these changes

Assignees
No one assigned
Labels
continuous-integration merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulysses4ever @ffaf1 @geekosaur