-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make --test-show-details=direct the default #8942
Conversation
ef1320a
to
5dccded
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At long last. Thanks for the docs.
does it no need automatic o manual tests? now it does not produce a log file by default it seems, and there is not broken test to update? 😢 not sure if it worths add the |
@jneira indeed, I was going to but forgot to address automated testing in the PR message. As it stands, i don't believe it's possible to use the current test suite to test this change, and the only way is Manual QA. I added a bit of notes for Manual QA but I could extend them, perhaps. I'm not very motivated to do that because I don't know if any manual QA will happen. I'd rather wait for a volunteer and see if they have particular questions. I'd be happy to answer. Recently i saw many kinds of PRs that require extending the test suite in order to be tested, unfortunately (all in different manner, of course). I don't think it's fair to require that much of an effort for either of those contributions. Otherwise we will just stall. |
I'm fine with applying any labels that people think would be helpful, of course. I'm not sure what that should be. |
5dccded
to
47c70d6
Compare
fix #7817, #8619
QA Notes
cabal test
on a simple package with a test suite should give more verbose results than under the previously releasedcabal
s. Before, if there are no failures, you wouldn't see which tests have been run. Now you will. Bonus: if the package employs one of the testing frameworks (hspec, tasty, sidtest), you will enjoy colored output (unlike with previouscabal
releases).Please include the following checklist in your PR:
Bonus points for added automated tests!