Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --test-show-details=direct the default #8942

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

ulysses4ever
Copy link
Collaborator

@ulysses4ever ulysses4ever commented May 8, 2023

fix #7817, #8619

QA Notes

cabal test on a simple package with a test suite should give more verbose results than under the previously released cabals. Before, if there are no failures, you wouldn't see which tests have been run. Now you will. Bonus: if the package employs one of the testing frameworks (hspec, tasty, sidtest), you will enjoy colored output (unlike with previous cabal releases).


Please include the following checklist in your PR:

Bonus points for added automated tests!

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At long last. Thanks for the docs.

@ulysses4ever ulysses4ever added merge me Tell Mergify Bot to merge and removed attention: needs-review labels May 8, 2023
@jneira
Copy link
Member

jneira commented May 8, 2023

does it no need automatic o manual tests? now it does not produce a log file by default it seems, and there is not broken test to update? 😢

not sure if it worths add the need test label tbh

@ulysses4ever
Copy link
Collaborator Author

ulysses4ever commented May 8, 2023

@jneira indeed, I was going to but forgot to address automated testing in the PR message. As it stands, i don't believe it's possible to use the current test suite to test this change, and the only way is Manual QA.

I added a bit of notes for Manual QA but I could extend them, perhaps. I'm not very motivated to do that because I don't know if any manual QA will happen. I'd rather wait for a volunteer and see if they have particular questions. I'd be happy to answer.

Recently i saw many kinds of PRs that require extending the test suite in order to be tested, unfortunately (all in different manner, of course). I don't think it's fair to require that much of an effort for either of those contributions. Otherwise we will just stall.

@ulysses4ever
Copy link
Collaborator Author

I'm fine with applying any labels that people think would be helpful, of course. I'm not sure what that should be.

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make --test-show-details=direct the default
4 participants