add line to address functionality #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since headcrabe does depend on std, it is not worth it to keep the fork of addr2line with the no_std attribute.
This commit change the file and line number to make them non optional. This will prevent certain invalid location from existing, since, for debugger, knowing that a instruction is related to a file but not knowing were is not meaningful. This commit also change the line and column number from u32 to NonZeroU32. In dwarf line and column number start at 1. if the line or column number were 0 it would mean that they are not specifies. Sadly, those change break the testing apparatus of addr2line. As they verify if the create produce the same result as gnu addr2line. Which include incomplete location (i.e instruction with know file, but unknown line and column number). I left fixing this problem as a todo
This method will be necessary for the line to address API that I have in mind.
This commit add a API to the fork of addr2line, which allow you to retrieve the addresses associate with a source location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.