Fix mobile toggle menu functionality #32
Conversation
…unctions, and updating event listeners
There was a problem hiding this comment.
The indentation changed in this file. Let's revert them.
|
|
||
| const toggle = e => e.classList.toggle('is-active'); | ||
| const toggleNav = ({ target }) => Array.from(navMenu.classList).includes('is-active') ? toggle(navMenu) : null; | ||
|
|
||
| hamburger.addEventListener('click', () => toggle(navMenu, 'is-active')); |
There was a problem hiding this comment.
How can I replicate the issue on my end? When I go to https://hassanali.me/studorlio/ using the mobile view, the hamburger menu works for me. I may be missing something.
screencast.2024-07-18.20-00-22.mp4
There was a problem hiding this comment.
Hello @helfi92 ,
I hope you are doing well.
I've reverted the changes to controller.js and restored it to its previous state.
And
It looks like the hamburger menu is working fine for me on mobile view, as well and I'm not able to replicate the issue. Since this issue was reported by someone else, it might be specific to certain devices or conditions.
Best Regards
There was a problem hiding this comment.
Asked the author of the issue for more information - #30 (comment)
Hello @helfi92 ,
I hope you are doing well,
I have done the changes or solved the issue, I hope it will be valuable.
Best Regards