Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home connect number platform with temperature set points entities #126145

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Diegorro98
Copy link
Contributor

@Diegorro98 Diegorro98 commented Sep 17, 2024

Breaking change

Proposed change

Add number platform and include temperature setpoints.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

EDIT: This platform fetches from the API the "step", maximum and minimum values at the entry setup, which might not be the best idea. It also fetches while updating the entity if at the entry setup wasn't able to obtaine the values, maybe this should be the only way to do it to avoid slow starts.

This PR will be keept in draft until #126143 gets merged, as some code can be refactored once merged, but it can be already reviewed as it will contain small changes.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @DavidMStraub, mind taking a look at this pull request as it has been labeled with an integration (home_connect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of home_connect can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign home_connect Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek
Copy link
Member

Only one platform per PR

@Diegorro98 Diegorro98 force-pushed the home_connect_number_time_platforms branch from d40cf4a to 5989cc2 Compare September 17, 2024 21:57
@Diegorro98 Diegorro98 changed the title Home connect temperature set points and alarm clock entities Home connect temperature number platform with set points entities Sep 17, 2024
@Diegorro98 Diegorro98 changed the title Home connect temperature number platform with set points entities Home connect number platform with temperature set points entities Sep 17, 2024
@Diegorro98 Diegorro98 force-pushed the home_connect_number_time_platforms branch from 5989cc2 to 8015c24 Compare September 18, 2024 19:15
@Diegorro98
Copy link
Contributor Author

I just deleted from the Number platform HomeConnectNumberEntityDescription because I thought that if no additional members were added, it wasn't needed. But I saw at other platforms from this integration that it contains entity descriptions without any additional members (for example, HomeConnectSwitchEntityDescription).
Should I keep HomeConnectNumberEntityDescription or should I delete it?

@joostlek
Copy link
Member

If there's no need to extend it, don't extend it :)

@Diegorro98 Diegorro98 force-pushed the home_connect_number_time_platforms branch from 403fc07 to 8015c24 Compare September 19, 2024 20:31
No longer fetched at entry setup
Copy link
Contributor

@beastie29a beastie29a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't seeing the temperature unit while testing the changes and saw that it wasn't being set. Added some other small changes/comments.

homeassistant/components/home_connect/number.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants