-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home connect number platform with temperature set points entities #126145
base: dev
Are you sure you want to change the base?
Home connect number platform with temperature set points entities #126145
Conversation
Hey there @DavidMStraub, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Only one platform per PR |
d40cf4a
to
5989cc2
Compare
5989cc2
to
8015c24
Compare
I just deleted from the Number platform |
If there's no need to extend it, don't extend it :) |
403fc07
to
8015c24
Compare
No longer fetched at entry setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't seeing the temperature unit while testing the changes and saw that it wasn't being set. Added some other small changes/comments.
Breaking change
Proposed change
Add number platform and include temperature setpoints.
Type of change
Additional information
EDIT: This platform fetches from the API the "step", maximum and minimum values at the entry setup, which might not be the best idea. It also fetches while updating the entity if at the entry setup wasn't able to obtaine the values, maybe this should be the only way to do it to avoid slow starts.
This PR will be keept in draft until #126143 gets merged, as some code can be refactored once merged, but it can be already reviewed as it will contain small changes.
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: