Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(vscode): add EditorConfig extension recommendation #1457

Merged
merged 1 commit into from
May 21, 2024

Conversation

ThomasFrans
Copy link
Contributor

@ThomasFrans ThomasFrans commented May 18, 2024

As Visual Studio Code is the most popular editor at the moment, it makes sense to recommend the EditorConfig extension because it's not included by default. Also enable the final newline in files again as that was the default until the EditorConfig file was added.

Describe your changes

  • Add extension recommendation file for Visual Studio Code and recommend the EditorConfig extension
  • Change the insert_final_newline option in the EditorConfig back to true

Issue ticket number and link

/

Checklist before requesting a review

  • Documentation was updated (i.e. due to changes in keybindings, commands, etc.)
  • Changelog was updated with relevant user-facing changes (eg. not dependency updates,
    not performance improvements, etc.)

As Visual Studio Code is the most popular editor at the moment, it makes
sense to recommend the EditorConfig extension because it's not included
by default. Also enable the final newline in files again as that was the
default until the EditorConfig file was added.
@ThomasFrans ThomasFrans marked this pull request as ready for review May 18, 2024 19:43
@hrkfdn hrkfdn merged commit dc64a29 into hrkfdn:main May 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants