review https://github.com/NixOS/nixpkgs/pull/239450

[TheBrainScrambler]

Things changed:

• split name into pname/version. This is the recommended way to do it, don't know why you use name
• left the unwrapped binary too in case someone is unhappy with the wrapper or wants to make his own wrapper
• https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md: "meta.description must: [...] Not end with a period (or any punctuation for that matter)."
  And some minor stuff

[hughobrien]

split name into pname/version. This is the recommended way to do it, don't know why you use name

Version wasn't used in the build.nix stage despite being passed in so I rejiggered it. It's obviously harmless though so easier to stick to the recommendations I guess.

[hughobrien]

In the interest of expediency I'm going to commit the suggestions but please yell if you disagree. Thanks again for helping with this.

[TheBrainScrambler]

Ah sorry looks like I didn't try to build my review, thought I did it :/ but yes it's good that you fixed those mistakes.

split name into pname/version. This is the recommended way to do it, don't know why you use name

Version wasn't used in the build.nix stage despite being passed in so I rejiggered it. It's obviously harmless though so easier to stick to the recommendations I guess.

Uuh, but it is used ? Line 16: inherit pname version src; Since you kept it there's nothing to change, but just to tell you that this change wasn't just harmless but actually needed. If you specify only name instead of pname/version it's going to think that name is pname-version basically. And since you don't give any version but just give the pname as name it would cause problems.