-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd] Add support for flags specifying filters type in vmmap, and allow multiple filters #1120
base: main
Are you sure you want to change the base?
Conversation
I will write docs and tests later :P |
No problem, I'll make this a draft then to see the diff with that's ready to review. Change the status when ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting addition but I think you should rewrite the parsing loop using the parse_arguments
decorator here. It would gain in simplicity and clarity.
…_arguments` decorator (#1122) Add support for the `append` action for ArgumentParser in the `parse_arguments` decorator on optional arguments. This makes us able to support this: ``` command --arg 1 --arg 2 --arg 3 ``` And get `[1, 2, 3]` as the `arg` value. This CL is required to make changes to #1120 before merging. --------- Co-authored-by: crazy hugsy <[email protected]>
…ow multiple filters Parse args: - `-a` / `--addr`: - filter by address -> parses the next arg as an int or asks gdb the value - `-n` / `--name`: - filter based on section name - If nothing is specified, print a warning and guess the type (previous behavior)
48ada57
to
ec99843
Compare
@hugsy @Grazfather @therealdreg PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR code looks good, but it needs to be tested more in depth for -n
and -a
IMO
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You can reopen it by adding a comment to this issue. |
Parse args:
-a
/--addr
:-n
/--name
: