Vertical scaling #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added check against qos change from resource patch
(2) added check against pod QOS change as a result of (1) (3) updated unit tests
…nnotation (2) fixed the duplicated update issue in (1) (3) added unit tests
(1) enabled job and pod resource change via patch (2) added check against qos change as a result of (1)
…engdu (1) added job controller changes to convert job spec resource update to annotation (2) fixed the duplicated update issue in (1) (3) added unit tests
* Kubelet changes to support vertical scaling * Kubelet changes for vertical scaling - code review feedback fixes
* Scheduler changes to support vertical resources scaling * Scheduler changes to support vertical resources scaling - code review fixes
…ce spec (2) added oomKillDisable annotation, passed down to pod level cgroup file memory.oom_control Tested on a local environment
added cgroup updates and oomKillDisable annotation
vertical scaling feature gate in apiserver and controller
tested using a manual e2e test
added vertical scaling feature gate to kubelet (related unit tests too)
…city (#31) Added unit-tests and fixes to address CR comments.
added resource quota control for pod resource update
* Add pod resource resize status to pod conditions * Handle InPlaceOnly policy through pod status update * Restore running pod resource values on resizing failure
* Update cached pod resources values on resizing updates - scheduler caches the initial pod that gets Added, and deletes cached Pod. So subsequent pod resource updates makes cached pod resource values to become stale. This fix updates cached pod resource values so the delete deducts the correct values.x * Addressed code review comments, minor fixes.
#35) * fixed the issue when pod resource is updated to decrease, resource quota is not updated immediately * added missing vertical scaling feature gates * fixed pod count issue per Vinay's PR comment
…ry resize retry. (#38) * Allow controller to process new resize requests after a failed request, add rudimentary resize retry.
…izing. Refactor code. (#40) * Respect the pod disruption budget when rescheduling pods. Refactor code. * Add unit test for checkPodDisruptionBudgetOk function.
…heduler support of vertical scaling. (#41) * Update policy to allow scheduler to update pod. Add comprehensive unit tests for scheduler. * kubelet unit tests enhancement to cover vertical scaling policies.
…43) * Cleanup event logs. Refactor resize action handling and add unit test for it. * Update container status hash upon successful UpdateContainerResoruces. * Remove action annotation set by processResizing when rescheduling pod.
added retry for resource update failure
…on load, retry latest template.spec values on completion. (#46)
* added resource in place update to deployment * removed unused lines * added testing info * fixed deployment resource update retry * added check against qos change for deployment spec udpate * added unit tests for deployment resource update and qos changes * addressed Vinay's PR comments * added error checking for PatchPodResourceAnnotation * Added patch to the controller policy to allow patching pod in the "default" namespace Thanks @vinay! * added test cases for JD * added test for restart policy * added test case for InPlacePreferred put testing scripts into a separate place * added a doc
…ource-limits CRI update (#49)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: