Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WSL Idris installation compatibility #263

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jmanuel1
Copy link
Contributor

The use case for this PR is that I have Idris installed through Pack in WSL. (I've considered installing Idris in Windows, but Pack doesn't support Windows.) Since Idris in Linux won't understand Widows paths, something needs to translate them. VS Code has a more advanced solution to this kind of problem, but Atom and Pulsar don't.

So I'm making this PR but I figure it might warrant more discussion since:

  • I'm adding a dependency, wsl-path, which is a wrapper around the wslpath tool installed in WSL distros. We could access the tool directly, but I don't think I knew it existed before I found the npm package.
  • More importantly, maybe someone thinks that translating paths is outside the purview of atom-language-idris and should be dealt with some other way

@melted
Copy link
Contributor

melted commented Mar 31, 2024

I think it makes sense to use the NPM package for convenience.

@jmanuel1 jmanuel1 marked this pull request as ready for review April 18, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants