Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the "Write Dump" layout tab based #276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpglmart
Copy link

@jpglmart jpglmart commented Nov 10, 2019

Hi ikarus23,

As a regular user of MifareClassicTool, I would like to thank all of your work and effort in this project. I tried to add #36 as accurately as I could, but let me give you a brief description of this pull request contents:

Activities

BasicFragmentActivity is a FragmentActivity which implements NFC related bussines logic (same logic that is implemented on BasicActivity activity) by overriding onResume(), onPause() and onNewIntent(Intent intent) methods.

WriteTagFragmentActivity, which extends from BasicFragmentActivity, implements data writing related bussines logic (same logic that is implemented on WriteTag activity) and it also manages all four new fragments, displaying them on their respective tab and implementing their interfaces.

Fragments

There are four new fragments:

  • WriteBlockFragment
  • WriteDumpFragment
  • FactoryFormatFragment
  • ValueBlockFragment

Each of these fragments handle user interaction with UI and use interfaces to communicate with managing activity (WriteTagFragmentActivity).

Layouts

There are five new layouts:

  • activity_write_tag_fragment_adapter
  • fragment_write_block
  • fragment_write_dump
  • fragment_factory_format
  • fragment_value_block

First layout includes all views displayed on WriteTagFragmentActivity and the rest of them include views displayed on fragments.

Dependencies

A new dependency (com.android.support:design:28.0.0) was added in order to include tabs.

Even WriteTag activity is not being used in this version, it was not deleted so it can be used as a reference. Please let me know about bugs you detect in this version. Thank you.

@jpglmart jpglmart changed the title issue_36 - Make the "Write Dump" layout tab based Make the "Write Dump" layout tab based Nov 10, 2019
@ikarus23
Copy link
Owner

Thank you very much! This is a nice contribution! As soon as I will find some time to work on MCT again, I will look into it (might not be before winter holidays).

@ikarus23
Copy link
Owner

I finally had some time to look into this. The code is great! But there are two visual things I'm not sure about. They are not your "fault", but they bother me...

  1. The check boxes look now like Android 2.3.
  2. My screen is not wide enough to show all four tabs. This might lead to some users on missing out all the available write functions.

I'm not sure what can be done to improve the experience and make all functions visible. Or if the layout should just stay the "shitty old way" ;)

Screenshot_20200817-125418

@@ -25,4 +25,5 @@ android {

dependencies {
implementation 'androidx.legacy:legacy-support-core-utils:1.0.0'
implementation 'com.android.support:design:28.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use AndroidX dep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants