Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

line_num = 0 for reported errors #346

Closed
zsoci opened this issue Jun 7, 2024 · 1 comment · Fixed by #347
Closed

line_num = 0 for reported errors #346

zsoci opened this issue Jun 7, 2024 · 1 comment · Fixed by #347
Labels
bug

Comments

@zsoci
Copy link

zsoci commented Jun 7, 2024

Bug Description

[//]:# no_throw, no_catch_expressions and no_dollar_space reports does not set line_num.

To Reproduce

[//]:# In VSCODE

Expected Behavior

[//]:# line_num is set correctly

Additional Context

  • OS: MacOS
  • Erlang version 26.2.2
  • rebar3 version 3.22.1
@zsoci zsoci added the bug label Jun 7, 2024
zsoci pushed a commit to zsoci/elvis_core that referenced this issue Jun 7, 2024
Add Line to relevant calls (inaka#346)
2a5b33a
@paulo-ferraz-oliveira paulo-ferraz-oliveira linked a pull request Jun 7, 2024 that will close this issue
Add Line to relevant calls (#346) #347
Merged
@paulo-ferraz-oliveira
Copy link
Collaborator

This was linked to your pull request (to be auto-closed when that one's merged). Thanks.

zsoci pushed a commit to zsoci/elvis_core that referenced this issue Jun 10, 2024
Add Line to relevant calls (inaka#346)
ceb0cb1
zsoci pushed a commit to zsoci/elvis_core that referenced this issue Jun 10, 2024
Add Line to relevant calls (inaka#346)
5c9b5f0
zsoci pushed a commit to zsoci/elvis_core that referenced this issue Jun 10, 2024
Add Line to relevant calls (inaka#346)
fdbf4d8
elbrujohalcon added a commit that referenced this issue Jun 10, 2024
@elbrujohalcon
Merge pull request #347 from zsoci/main
fe55f05 
Add Line to relevant calls (#346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Line to relevant calls (#346) zsoci/elvis_core
2 participants
@paulo-ferraz-oliveira @zsoci