Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Line to relevant calls (#346) #347

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Add Line to relevant calls (#346) #347

merged 1 commit into from
Jun 10, 2024

Conversation

zsoci
Copy link

@zsoci zsoci commented Jun 7, 2024

No description provided.

@paulo-ferraz-oliveira
Copy link
Collaborator

@zsoci, the change seems reasonable. Once #348 is merged, though, I'd like to ask you to rebase onto the main branch, for CI to run (sorry about this).

@paulo-ferraz-oliveira paulo-ferraz-oliveira linked an issue Jun 7, 2024 that may be closed by this pull request
@elbrujohalcon
Copy link
Member

@zsoci / @paulo-ferraz-oliveira : #348 is merged. Please, merge or rebase.

@elbrujohalcon
Copy link
Member

🤔 Some tests are failing… Did rebar3 test run cleanly for you, @zsoci ?

@zsoci
Copy link
Author

zsoci commented Jun 10, 2024

Seems it is not related to the change. rebar3 test passes on OTP 24 and 26. I do not have 27, anyway will try to fix it.

@elbrujohalcon
Copy link
Member

Thank you, @zsoci !! :)

@elbrujohalcon elbrujohalcon merged commit fe55f05 into inaka:main Jun 10, 2024
9 checks passed
@paulo-ferraz-oliveira
Copy link
Collaborator

This was released (GitHub) in 3.2.5: https://github.com/inaka/elvis_core/releases/tag/3.2.5
This was published (Hex.pm) in 3.2.5: https://hex.pm/packages/elvis_core/3.2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

line_num = 0 for reported errors
3 participants