Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Defer buffer release when no host memory to be updated #6837

Merged
merged 68 commits into from
Dec 8, 2022
Merged

[SYCL] Defer buffer release when no host memory to be updated #6837

merged 68 commits into from
Dec 8, 2022

Commits on Sep 20, 2022

  1. [SYCL] Mark mem object which may have not blocking dtor according to … 

    …Spec2020

Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    0601210 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. Add draft how to delay buffer_impl release 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    aff3be6 View commit details
    Browse the repository at this point in the history

  2. Update symbols for non-breaking change 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    1195b59 View commit details
    Browse the repository at this point in the history

  3. Update abi test vtable.cpp - non-breaking change 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    8d05802 View commit details
    Browse the repository at this point in the history

  4. Update SYCL_MINOR_VERSION for non-breaking ABI change 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    b54b8e4 View commit details
    Browse the repository at this point in the history

  5. Remove ABI break 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    965a015 View commit details
    Browse the repository at this point in the history

  6. Update symbols to new version 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    27ccbff View commit details
    Browse the repository at this point in the history

  7. Tiny rename 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    9540fe0 View commit details
    Browse the repository at this point in the history

  8. Revert "Update abi test vtable.cpp - non-breaking change" 

    This reverts commit 8d05802.
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    c00c7cb View commit details
    Browse the repository at this point in the history

  9. Remove isDefault method, reimplemented 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    661dace View commit details
    Browse the repository at this point in the history

  10. Fix symbols again 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    6615db3 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Add handling of deferred mem objects release 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    8174dc3 View commit details
    Browse the repository at this point in the history

  2. Remove unused function and restore XPTI traces collection 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    d55405e View commit details
    Browse the repository at this point in the history

  3. Add skeleton for unit test 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    bb2c4fb View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. Fix shared_ptr use_count check 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    5db9e85 View commit details
    Browse the repository at this point in the history

  2. Test draft 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    53a1892 View commit details
    Browse the repository at this point in the history

  3. [SYCL] Align usm_allocator ctor and operators with SYCCL2020 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    4b0a3fa View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Update attach scheduler logic 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    8daea20 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Make cleanup iterative 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    c855f13 View commit details
    Browse the repository at this point in the history

  2. Fix test utils impl error 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    8dbcd1c View commit details
    Browse the repository at this point in the history

  3. Add other tests for buffer contructors 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    0f61c64 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Other tests for high level buffer destruction deferring logic 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    ddf215b View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Add unittest for waitForRecordToFinish 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    23bea82 View commit details
    Browse the repository at this point in the history

  2. Remove debug flags uploaded by mistake 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    aa41d76 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'sycl' into buff_detach

    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    e296d03 View commit details
    Browse the repository at this point in the history

  4. Fix clang-format 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    179c472 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Update test to not keep ill-formed objects 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    2076c7c View commit details
    Browse the repository at this point in the history

  2. Check command destruction 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    e911d0a View commit details
    Browse the repository at this point in the history

  3. Fix clang-format 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    81c2b09 View commit details
    Browse the repository at this point in the history

  4. Handle set_final_data usage 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    edcfcfc View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Fix code-review comments (round 1) 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    b5e85de View commit details
    Browse the repository at this point in the history

  2. Fix missed comments 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    a5980a0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'sycl' into buff_detach

    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    ac06f1b View commit details
    Browse the repository at this point in the history

  4. Remove nagation from variable name and logic 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    09b8359 View commit details
    Browse the repository at this point in the history

  5. Simplify deferred mem objects release - do not aggregate to capture lock 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    1e75448 View commit details
    Browse the repository at this point in the history

  6. Return trace of stream buffer emptyness to scheduler destructor 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    484b1cf View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Fix comments (round 2) 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    1061322 View commit details
    Browse the repository at this point in the history

  2. Fix comments (round 3) 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    d4537a3 View commit details
    Browse the repository at this point in the history

  3. Fix build 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    342ff91 View commit details
    Browse the repository at this point in the history

  4. Fix comments & tests (round 4) 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    fdab0e7 View commit details
    Browse the repository at this point in the history

  5. Predict comments: restore removeMemoryObject content 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    0872d7c View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Fix root cause of hang when host task is not even started upon releas… 

    …e of all resouces

Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    3a25f1e View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Fix comments (round n) 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    28f008d View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Merge branch 'sycl' into buff_detach

    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    92b5e15 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. [ESIMD] Implement piEventGetInfo for event execution status 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    6247f8a View commit details
    Browse the repository at this point in the history

  2. Move comment to the right place 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    4133862 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. cv.notify_all should not be called under mutex paired with cv 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    79b2125 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Remove default allocator check after SYCL2020 update 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    868973c View commit details
    Browse the repository at this point in the history

  2. Update unittests due to default allocator check removal 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    1bc8e57 View commit details
    Browse the repository at this point in the history

  3. Update symbols after parameter removal 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    6e0943b View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Try to align hip context destruction handling with cuda WA 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    1c62d08 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Merge branch 'sycl' into buff_detach

    @KseniyaTikhomirova
    KseniyaTikhomirova committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    30dfaf2 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Fix unit test after mock plugin rework 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    60e3011 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Merge branch 'sycl' into buff_detach

    @KseniyaTikhomirova
    KseniyaTikhomirova committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    6964876 View commit details
    Browse the repository at this point in the history

  2. DRAFT: try to release scheduler resources earlier using thread_local … 

    …utility class

Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    3d5315e View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Draft: try to release scheduler resources earlier, fix counter declar… 

    …ation

Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    467a9ea View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. Release scheduler resources earlier

    @KseniyaTikhomirova
    KseniyaTikhomirova committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    0b9032a View commit details
    Browse the repository at this point in the history

  2. change location for buff release attempt 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>

	.git/CHERRY_PICK_HEAD
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    9d570ce View commit details
    Browse the repository at this point in the history

  3. Code cleanup 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    c6d5dc7 View commit details
    Browse the repository at this point in the history

  4. Code cleanup Part 2 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    a0b37ef View commit details
    Browse the repository at this point in the history

  5. Revert "Try to align hip context destruction handling with cuda WA" 

    This reverts commit 1c62d08.
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    619ee4e View commit details
    Browse the repository at this point in the history

  6. Return cleanup deferred buffers to cleanupCommands call 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    3187f0a View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary variable in ObjectRefCounter 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    dbe88e2 View commit details
    Browse the repository at this point in the history

  8. Fix hang 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    06e2608 View commit details
    Browse the repository at this point in the history

  9. Fix comments 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    71e9048 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'sycl' into buff_detach

    @KseniyaTikhomirova
    KseniyaTikhomirova committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    a89e577 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Prevent warning as error for release build 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    ceea7f8 View commit details
    Browse the repository at this point in the history

  2. wprotectMDeferredMemObjRelease modification with mutex 

    Signed-off-by: Tikhomirova, Kseniya <[email protected]>
    @KseniyaTikhomirova
    KseniyaTikhomirova committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    1f201a9 View commit details
    Browse the repository at this point in the history