Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Fix segfault on program exit when user thread is not finished yet #7908

Merged
merged 10 commits into from
Jan 6, 2023

Conversation

KseniyaTikhomirova
Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova commented Jan 3, 2023

(caused by #6837)

Signed-off-by: Tikhomirova, Kseniya [email protected]

@KseniyaTikhomirova KseniyaTikhomirova marked this pull request as ready for review January 4, 2023 16:10
@KseniyaTikhomirova KseniyaTikhomirova requested a review from a team as a code owner January 4, 2023 16:10
sycl/source/detail/global_handler.cpp Outdated Show resolved Hide resolved
sycl/source/detail/global_handler.cpp Outdated Show resolved Hide resolved
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
@KseniyaTikhomirova
Copy link
Contributor Author

/testwin

Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KseniyaTikhomirova
Copy link
Contributor Author

/summary:run

@bader bader changed the title Fix segfault on program exit when user thread is not finished yet (ca… [SYCL] Fix segfault on program exit when user thread is not finished yet Jan 6, 2023
@bader bader merged commit ac58dd3 into intel:sycl Jan 6, 2023
@cperkinsintel
Copy link
Contributor

@KseniyaTikhomirova @romanovvlad

This PR is leading to a bunch of TimeOuts on llvm-test-suite when we test Windows. Pretty much every PR since it's been merged ( for example: intel/llvm-test-suite#1500 ). There are a couple of tests that consistently lock up ( HostInteropTask/host-task-failure.cpp ) and others that are inconsistent. Meaning, I can get between 7 to 12 of them to lock up if I run the test suite locally, but many of those same tests pass if run individually.

The "/testwin" directive only makes sure something is buildable on windows and the in-tree tests are run, but not the llvm-test-suite tests on Windows. Likewise, my last understanding is that "summary:run" doesn't do anything presently either.

@KseniyaTikhomirova
Copy link
Contributor Author

KseniyaTikhomirova commented Jan 10, 2023

@cperkinsintel, I unintentionally moved thread pool drain out of win32 check. FIxed here #7973

bader pushed a commit that referenced this pull request Jan 10, 2023
PR #7908 accidentally introduced a behavior that causes lots of timeouts
on the CI system on Windows.

Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants