This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
namespace fix for bg-location #1451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BackgroundGeolocation plugin from transitorsoft was updated in 2015 such that the namespace of the plugin changed. This PR fixes the undefined error that results when ngCordova tries to implement the plugin. Although I have not tested the backwards compatibility of this change, I am confident that it should still work for anyone using an older version of the plugin.
The following PR is a reference to the upstream change
christocracy/cordova-plugin-background-geolocation#208
I recommend not removing the plugin from ngCordova codebase because some people may still want to pay for the software and utilize this functionality. #1114