Add support for more grippers, py3 compatability and code improvements #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipa-danb
reviewed
Jul 11, 2024
|
Yes,
yes,
yes,
idk -> probably wrong
Von: Daniel Bargmann ***@***.***>
Gesendet: Donnerstag, 11. Juli 2024 17:38
An: ipa320/weiss_gripper_ieg76 ***@***.***>
Cc: Subscribed ***@***.***>
Betreff: Re: [ipa320/weiss_gripper_ieg76] Rewrite of ptenbrock (PR #4)
@ipa-danb commented on this pull request.
________________________________
In package.xml<#4 (comment)>:
- <!-- One maintainer tag required, multiple allowed, one person per tag -->
- <!-- Example: -->
- <!-- <maintainer ***@***.******@***.***>">Jane Doe</maintainer> -->
- <maintainer ***@***.******@***.***>">lth-vd</maintainer>
+ <maintainer ***@***.******@***.***>">ipa-pgt</maintainer>
This is probably not right anymore
________________________________
In src/weiss_gripper_ieg76/driver.py<#4 (comment)>:
@@ -17,14 +17,27 @@ def __init__(self):
self.states_publisher_thread = StatesPublisher(0.8, self.serial_port_comm)
rospy.on_shutdown(self.shutdown_handler)
+ def set_max_pos(self, gripper_info):
So do we support all those grippers? We should add this to the description and change the name in a future PR?
________________________________
In src/weiss_gripper_ieg76/serial_comm.py<#4 (comment)>:
@@ -161,6 +167,7 @@ def send_command(self, command, grasping_force = 100, opening_position = 29.50,
self.log_debug_flags()
try:
+ # print 'Out: ', payload
⬇️ Suggested change
- # print 'Out: ', payload
________________________________
In urdf/ieg55.urdf.xacro<#4 (comment)>:
@@ -23,7 +23,7 @@
</visual>
</link>
- <joint name="${prefix}jaw_position" type="prismatic">
+ <!-- <joint name="${prefix}jaw_position" type="prismatic">
why?
—
Reply to this email directly, view it on GitHub<#4 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AARDOLKY24LMYJCV6CP7T23ZL2RERAVCNFSM6AAAAABEP2RCTCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZSGI4DSNRYGI>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.******@***.***>>
|
|
i added you as maintainer @ipa-lth - OK? then lgtm and merge |
ipa-danb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ipa-danb do you see any reasons why this should not be merged into master branch?