Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playset support #452

Merged
merged 29 commits into from
Aug 9, 2024
Merged

Playset support #452

merged 29 commits into from
Aug 9, 2024

Conversation

cwegrzyn
Copy link
Collaborator

No description provided.

@cwegrzyn cwegrzyn self-assigned this Jul 26, 2024
@cwegrzyn cwegrzyn force-pushed the cwegrzyn/issue414-Playset-support branch from e788b56 to 68e534c Compare July 28, 2024 01:33
@cwegrzyn cwegrzyn force-pushed the cwegrzyn/issue414-Playset-support branch from 0cf4d05 to b2ff404 Compare July 29, 2024 02:42
@cwegrzyn
Copy link
Collaborator Author

cwegrzyn commented Aug 3, 2024

Some things left to do:

  • deal with the source/ruleset index
    • option 1: if a move is matched, the ruleset_for_move should be matched as well
    • option 2: change how we index things to make the _source entry always accessible (i.e., embedded moves get their parent source)
  • Remove global dataset settings
  • Use nice icons for built in playsets
  • Onboarding flow for existing campaigns
  • Docs

@cwegrzyn cwegrzyn merged commit bc0c842 into main Aug 9, 2024
4 checks passed
@cwegrzyn cwegrzyn deleted the cwegrzyn/issue414-Playset-support branch August 9, 2024 01:45
@cwegrzyn cwegrzyn mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants