Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESLint8 to peerDependencies #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

IvanGoncharov
Copy link
Contributor

No description provided.

@IvanGoncharov
Copy link
Contributor Author

@coreyfarrell This change blocks us from upgrading to ESLint v8.
CI fails since package-lock.json is not updated.
I can update it locally but I have a new NPM version that will rewrite the entire file.
Can you please take a look?
Also would be great if you update package-lock.json to v2.

@IvanGoncharov
Copy link
Contributor Author

@coreyfarrell Can you please look into it?

@dhurlburtusa
Copy link

Did you consider using >=6.0.0 for the version instead of ^6.0.0 || ^7.0.0 || ^8.0.0? The former will include v9, v10, etc of ESLint. The latter won't.
The pro is that we won't have to keep updating the peer dependency versions every time a new compatible ESLint version comes out. The con is that there is a possibility a new ESLint version is incompatible. (My guess is that that would be very unlikely. And if it does happen, then the behavior of the developer will still be the same (don't use with the incompatible ESLint) but they won't get an error message when running npm install or similar until the incompatible version is filtered out.)

osmestad added a commit to tidal-music/eslint-config-tidal that referenced this pull request Sep 7, 2023
…w flat config format.

Needs: `npm install --force` to accept outdated peer dependency of `eslint-plugin-istanbul` see: istanbuljs/eslint-plugin-istanbul#17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants