Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rimraf and glob #1565

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

danielbeeke
Copy link

Here is a pull request for updating the glob and rimraf version.
I am trying to remove the deprecation warnings.
Sorry for the previous pull request that one is only for glob.

@bcoe
Copy link
Member

bcoe commented Jun 9, 2024

@danielbeeke thank you for the PR, things seem to mostly be working, but rimraf has a new error it's throwing on Windows:

throw Object.assign(new Error('Illegal characters in path.'), {

Anything jump out at you, for what might be causing this?

@danielbeeke
Copy link
Author

It seems glob argument needs to be added for windows only.

See: isaacs/rimraf#249

@danielbeeke
Copy link
Author

Hi @bcoe would it be possible to run the CI again?
I would love to see this resolved. If needed I can do more work on the code.

@danielbeeke
Copy link
Author

Is there another maintainer that can help with the CI? It just needs to be triggered I think.
I would love to remove the deprecated warning in my projects.

@bcoe
Copy link
Member

bcoe commented Jun 26, 2024

Hey @danielbeeke still getting quite a few "not ok" errors with Windows.

If you can get it green I'll bump the deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants