Lock EnumCodec.membersMap during reads and writes #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been seeing a nondeterministic `fatal error: concurrent map writes` error while using PGX. I traced it to the `c.membersMap[s] = s` line, and I think that this is a true issue - there doesn't appear to be anything preventing concurrent access to this map. This PR adds a `sync.RWMutex` to `EnumCodec` and calls the appropriate `RLock` or `Lock` methods around read or write access.
jamesroutley
commented
Jul 16, 2024
| } | ||
|
|
||
| func (EnumCodec) FormatSupported(format int16) bool { | ||
| func (*EnumCodec) FormatSupported(format int16) bool { |
There was a problem hiding this comment.
I needed to make these pointer receivers to avoid FormatSupported passes lock by value: github.com/jackc/pgx/v5/pgtype.EnumCodec contains sync.RWMutex go vet errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing a nondeterministic
fatal error: concurrent map writeserror while using PGX. I traced it to thec.membersMap[s] = sline, and I think that this is a true issue - there doesn't appear to be anything preventing concurrent access to this map.This PR adds a
sync.RWMutextoEnumCodecand calls the appropriateRLockorLockmethods around read or write access.